Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak in OpenSim::CoordinateCouplerConstraint::setFunction … #3547

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Fix memory leak in OpenSim::CoordinateCouplerConstraint::setFunction … #3547

merged 1 commit into from
Sep 13, 2023

Conversation

adamkewley
Copy link
Contributor

@adamkewley adamkewley commented Sep 13, 2023 •
edited by aymanhab
Loading

Fixes issue #3541

Brief summary of changes

  • Removes unnecessary .clone() call, which was creating a leaking temporary

Testing I've completed

  • None (hopefully it's obvious?)

Looking for feedback on...

CHANGELOG.md (choose one)

  • updated.

This change is Reviewable

@nickbianco nickbianco self-requested a review September 13, 2023 16:54
@nickbianco nickbianco merged commit 927d556 into main Sep 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickbianco nickbianco nickbianco approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adamkewley @nickbianco